feat: Allow linting files outside of project folder #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okonet
previously approved these changes
Sep 18, 2018
|
|
||
| ### Can I lint files outside of the current project folder? | ||
|
|
||
| tl;dr: Yes, but the pattern should start with `../`. |
There was a problem hiding this comment.
Perhaps add a config example here?
README.md
Outdated
|
|
||
| By default, `lint-staged` executes linters only on the files present inside the project folder(where `lint-staged` is installed and run from). | ||
| This is relevant _only_ when the project folder is a child folder inside the git repo. | ||
| In certain project setups, it might be desirable to bypass this restriction so `lint-staged` provides an escape hatch for the same(`>= v7.3.0`). |
There was a problem hiding this comment.
I’d drop from “so...” and connect with the next paragraph
Only when pattern starts with `../`.
sudo-suhas
force-pushed
the
feat/lint-outside-prj
branch
from
0a307e9
to
af538a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
==========================================
+ Coverage 97.93% 97.94% +<.01%
==========================================
Files 12 12
Lines 242 243 +1
Branches 28 29 +1
==========================================
+ Hits 237 238 +1
Misses 5 5
Continue to review full report at Codecov.
|
|
I created a full fledged working example and have linked to that from the readme FAQ. |
okonet
approved these changes
Sep 20, 2018
This was referenced Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files are not filtered only when pattern starts with
../. This avoids adding another flag to the config and should work as expected for existing users.Closes #425.
Closes #487.
Closes #492.