Added mount/unmount APIs to ReactWrapper #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lelandrichardson
force-pushed
the
lmr--mount-unmount
branch
from
2bc779a
to
3d10379
Compare
|
@ljharb or @goatslacker PTAL. I'm adding documentation right now. will update with that in a sec. |
lelandrichardson
force-pushed
the
lmr--mount-unmount
branch
from
3d10379
to
1c4cff7
Compare
|
Also important to note: This PR changes our jsdom test strategy to load a single document for the entire test suite, which is the strategy we will be recommending moving forward (in enzyme 2.0 and onward) |
|
LGTM |
lelandrichardson
added a commit
that referenced
this pull request
Feb 2, 2016
Added mount/unmount APIs to ReactWrapper
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These APIs only work if you are using a single document across tests, rather than using the
describeWithDOMmethod which recycles the global document. This is because React caches a reference to the global document under the hood, which we can not do anything about unfortunately.